[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

[Timm Bäder via Phabricator via cfe-commits]

tbaeder marked an inline comment as done.
tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:726
+  } else if (const auto *IVIE = dyn_cast<ImplicitValueInitExpr>(Initializer)) {
+    const ArrayType *ArrayType = IVIE->getType()->getAsArrayTypeUnsafe();
+    assert(ArrayType);
----------------
aaron.ballman wrote:
> (Sorry, I hadn't noticed you were using a type name as a variable name before! That sometimes confuses IDEs, so suggesting a different name.)
I can't say I saw that when making the change, but now that I see it, yes, that might've been the reason I used `auto` here. Anyway, I changed that, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135013/new/

https://reviews.llvm.org/D135013