[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 11:04:49 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a naming quirk, LGTM



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:726
+  } else if (const auto *IVIE = dyn_cast<ImplicitValueInitExpr>(Initializer)) {
+    const ArrayType *ArrayType = IVIE->getType()->getAsArrayTypeUnsafe();
+    assert(ArrayType);
----------------
(Sorry, I hadn't noticed you were using a type name as a variable name before! That sometimes confuses IDEs, so suggesting a different name.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135013/new/

https://reviews.llvm.org/D135013



More information about the cfe-commits mailing list