[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 18:55:21 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:5180
+    int RW = cast<ConstantInt>(Call.getArgOperand(1))->getZExtValue();
+    int Locality = cast<ConstantInt>(Call.getArgOperand(2))->getZExtValue();
+    int Data = cast<ConstantInt>(Call.getArgOperand(3))->getZExtValue();
----------------
Should add new verifier tests for this.

Also, if this requires any auto upgrade, I would appreciate adding address space mangling to the intrinsic at the same time 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136145/new/

https://reviews.llvm.org/D136145



More information about the cfe-commits mailing list