[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:7574
 
-  if (NumArgs > 3)
+  if (NumArgs > 4)
     return Diag(TheCall->getEndLoc(),
----------------
craig.topper wrote:
> craig.topper wrote:
> > Not clear to me that we should be changing the definition of `__builtin_prefetch`.
> > 
> > It wouldn't cost much to add a new builtin for X86 for the new instructions.
> It definitely shouldn't be buried in this patch the way it is currently titled and described.
Sure, I have added a new builtin in D136040. But I don't see any concerns for this patch so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136145/new/

https://reviews.llvm.org/D136145