[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 15:42:44 PDT 2022


jansvoboda11 added a comment.

In D135634#3866353 <https://reviews.llvm.org/D135634#3866353>, @benlangmuir wrote:

> I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line.

My understanding is that `ASTUnit` never uses command-line and always adopts whatever is in the PCM.

In D135634#3866528 <https://reviews.llvm.org/D135634#3866528>, @bnbarham wrote:

> Do reproducers read PCMs at all or do they rebuild from the headers?

I don't know. How are they related to this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135634/new/

https://reviews.llvm.org/D135634



More information about the cfe-commits mailing list