[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

Tue Oct 18 14:24:32 PDT 2022

bnbarham added a comment.

In D135634#3866353 <https://reviews.llvm.org/D135634#3866353>, @benlangmuir wrote:

> I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line.
>
> @bnbarham any concern about overlay vs chaining behaviour here? I remember you looking at that a while ago.

It still chains right now since I never ended up finishing those patches. This does explicitly *chain* with the command-line specified FS, not sure if one makes sense over the other here. Should we be passing in the real FS to the overlay creation here and then creating an actual overlay FS with both the original FileManager VFS + the PCM VFS (or building the overlay from scratch with the original overlays as well, though that still chains so...)?

Do reproducers read PCMs at all or do they rebuild from the headers?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135634/new/

https://reviews.llvm.org/D135634