[PATCH] D136040: [X86] Support PREFETCHI instructions

Ulrich Weigand via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 07:37:15 PDT 2022


uweigand added a comment.

In D136040#3862225 <https://reviews.llvm.org/D136040#3862225>, @pengfei wrote:

> 3. Add semacheck for prefetch write to instruction cache;
>
> I think the affected ARM and SystemZ tests are not valid before. Could @t.p.northover and @uweigand help to have a look?

This seems to be a semantic change.   The Language Reference does not spell out that a write prefetch on the instruction cache is prohibited.  In fact, I read it to explicitly state that every flavor of the prefetch intrinsic that doesn't match anything supported on the target architecture should simply be a no-op.  (I could imagine that on certain architectures, you might even have such a prefetch, e.g. to handle self-modifying code more efficiently.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136040/new/

https://reviews.llvm.org/D136040



More information about the cfe-commits mailing list