[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary
Christopher Di Bella via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 12 15:16:49 PDT 2022
cjdb created this revision.
cjdb added reviewers: aaron.ballman, erichkeane, shafik.
Herald added a subscriber: arphaman.
Herald added a project: All.
cjdb requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The [Improving Clang's Diagnostics RFC][1] identifies eight broad fields
for Clang to surface, two of which are text-based. Since the current
diagnostics more closely map to the diagnostic summary (or headline), we
should rename them to ensure that there's no confusion when
Diagnostic.Reason is introduced in the near future.
[1]: https://discourse.llvm.org/t/rfc-improving-clang-s-diagnostics/62584
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135820
Files:
clang/include/clang/Basic/Diagnostic.td
clang/include/clang/Basic/DiagnosticCommonKinds.td
clang/include/clang/Basic/DiagnosticFrontendKinds.td
clang/include/clang/Basic/DiagnosticLexKinds.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/test/TableGen/DiagnosticBase.inc
clang/utils/TableGen/ClangDiagnosticsEmitter.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135820.467276.patch
Type: text/x-patch
Size: 23912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221012/732bdd1d/attachment-0001.bin>
More information about the cfe-commits
mailing list