[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added a comment.

In D135634#3850224 <https://reviews.llvm.org/D135634#3850224>, @akyrtzi wrote:

> This seems fine to me but note that we no longer depend on the functionality that `test/Index/index-module-with-vfs.m` is testing (and not sure anyone else does), so if there is another change affecting it that is more complicated we could consider removing the test.

Thanks, good to know. Other users of `ASTUnit` might be relying on that (e.g. replay AST), so still I think it would be nice to land this. Though it seems this requires D67010 <https://reviews.llvm.org/D67010> ([Modules] Move search paths from control block to unhashed control block). That's because the unhashed control block is read **before** we start validating imports (and their input files). Without that patch, `test/Index/index-module-with-vfs.m` still starts to fail in D135636 <https://reviews.llvm.org/D135636>. Another solution would be to ensure the options block is serialized at the start of the control block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135634/new/

https://reviews.llvm.org/D135634