[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 11 11:15:15 PDT 2022


akyrtzi added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4715
+  return createVFSFromOverlayFiles(CI.getHeaderSearchOpts().VFSOverlayFiles,
+                                   Diags, BaseFS);
+}
----------------
A bit nitpick but I'd suggest changing to `std::move(BaseFS)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135634/new/

https://reviews.llvm.org/D135634



More information about the cfe-commits mailing list