[PATCH] D129443: [clang-format] Add option for aligning requires clause body

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 19:19:28 PDT 2022


owenpan added a comment.

In D129443#3842427 <https://reviews.llvm.org/D129443#3842427>, @HazardyKnusperkeks wrote:

> We can //fix// that regression, and I will adopt this change for my company to keep the requires expressions where they are. :)

Then we have three options:

1. Only fix the "regression".
2. Add the option and make `OuterScope` the default.
3. Add the option and make `Keyword` the default.

@HazardyKnusperkeks I will defer to your choice. :)



================
Comment at: clang/unittests/Format/FormatTest.cpp:20036
   Style.Language = FormatStyle::LK_Cpp;
+  CHECK_PARSE_BOOL(AlignRequiresClauseBody);
   CHECK_PARSE_BOOL(AlignTrailingComments);
----------------
HazardyKnusperkeks wrote:
> Please add the parsing test for the enum.
@rymiel Is this done?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129443/new/

https://reviews.llvm.org/D129443



More information about the cfe-commits mailing list