[PATCH] D129443: [clang-format] Add option for aligning requires clause body

Fri Oct 7 02:30:55 PDT 2022

HazardyKnusperkeks added a comment.

In D129443#3841248 <https://reviews.llvm.org/D129443#3841248>, @owenpan wrote:

> Is this option really required? Can we just fix the regression as reported in https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't followed the policy <https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options> lately when adding new options.

If it's a regression or not is a matter of perspective. Before my patch there were no real handling of concepts and they just looked like that. I had changed that (on purpose) if I remember correctly to bring in closer to lambdas.
We can //fix// that regression, and I will adopt this change for my company to keep the requires expressions where they are. :)

Also asking for a style guide concerning concepts and requires is a bit hard I think, I think in none of the styles we implement it is mentioned, it at least wasn't when I added the handling.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129443/new/

https://reviews.llvm.org/D129443