[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

Fri Sep 30 06:03:20 PDT 2022

10ne1 added a comment.

In D134454#3826179 <https://reviews.llvm.org/D134454#3826179>, @MaskRay wrote:

> In D134454#3826143 <https://reviews.llvm.org/D134454#3826143>, @10ne1 wrote:
>
>> In D134454#3824571 <https://reviews.llvm.org/D134454#3824571>, @MaskRay wrote:
>>
>>> I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
>>> This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in `linux-cross.cpp`).
>>> I'll add the test, though, and submit this for you.
>>>
>>> Request changes for now.
>>
>> Ok. Thanks, please ping if you need any action on my side.
>
> My latest thought is that this patch is going toward a wrong direction: https://reviews.llvm.org/D134454#3824630

To verify I understand correctly what you are suggesting: should we close this review and wait for distros like Arch to specify the sysroots via the new config files mechanism? (Arch is currently at LLVM 14.0.6, not sure when they will upgrade).

This will also block the kernel cleanups, but if @nickdesaulniers also agrees to postpone that kernel work, then ok, let's wait.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454