[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 29 23:51:42 PDT 2022


MaskRay added a comment.

In D134454#3826143 <https://reviews.llvm.org/D134454#3826143>, @10ne1 wrote:

> In D134454#3824571 <https://reviews.llvm.org/D134454#3824571>, @MaskRay wrote:
>
>> I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
>> This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in `linux-cross.cpp`).
>> I'll add the test, though, and submit this for you.
>>
>> Request changes for now.
>
> Ok. Thanks, please ping if you need any action on my side.

My latest thought is that this patch is going toward a wrong direction: https://reviews.llvm.org/D134454#3824630


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454



More information about the cfe-commits mailing list