[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

[Michał Górny via Phabricator via cfe-commits]

mgorny added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:1073
+  if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) {
+    if (*NoConfigEnv)
+      return false;
----------------
MaskRay wrote:
> Looking at LLDB_LAUNCH_FLAG_DISABLE_ASLR/LIBCLANG_DISABLE_PCH_VALIDATION, they don't check whether the value is non-empty.
Well, my personal experience tells me that it's sometimes non-trivial to unset var while setting it to empty value is easier, e.g.:

```
# undo global
CLANG_NO_DEFAULT_CONFIG= clang ...
# vs. env -u (not in POSIX)
env -u CLANG_NO_DEFAULT_CONFIG ...
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134905/new/

https://reviews.llvm.org/D134905