[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

The concept LGTM.



================
Comment at: clang/lib/Driver/Driver.cpp:1073
+  if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) {
+    if (*NoConfigEnv)
+      return false;
----------------
Looking at LLDB_LAUNCH_FLAG_DISABLE_ASLR/LIBCLANG_DISABLE_PCH_VALIDATION, they don't check whether the value is non-empty.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134905/new/

https://reviews.llvm.org/D134905