[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

[Michał Górny via Phabricator via cfe-commits]

mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:1089
+
+  bool ModeSuffixUnique = !ClangNameParts.ModeSuffix.empty() &&
+                          ClangNameParts.ModeSuffix != RealMode.str();
----------------
sepavloff wrote:
> mgorny wrote:
> > sepavloff wrote:
> > > Can the variable name be better? It looks like it means that driver mode is replaced (overridden).
> > Can you suggest a better name? It's used to avoid searching for the same filename twice.
> DriverModeReplaced? Or something like that.
Ok, how about something more literal? `TryModeSuffix`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134337/new/

https://reviews.llvm.org/D134337