[PATCH] D134507: [Clang] add missing ClangABICompat check

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 11:48:33 PDT 2022


rjmccall added a comment.

I don't think I agree that changes to template partial ordering rules are "ABI-breaking changes".  They're breaking changes to *language semantics*, and the ABI break is downstream of that, just like any other semantic change to overload resolution would be.  I think the right approach for Clang is to gate this by language version and add a note somewhere that C++23 changed the overload resolution rules around function templates and that this means adopting C++23 can be ABI-breaking.  Fortunately, it should only be ABI-breaking in rare circumstances.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134507/new/

https://reviews.llvm.org/D134507



More information about the cfe-commits mailing list