[PATCH] D134507: [Clang] add missing ClangABICompat check

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 11:32:05 PDT 2022


ychen added a comment.

In D134507#3817928 <https://reviews.llvm.org/D134507#3817928>, @probinson wrote:

> It feels odd to use a ClangABI check for something that is affecting what source is accepted, but this is not my area of expertise.
> @aaron.ballman or @rjmccall would probably be the right people to weigh in on this.

This was discussed here https://reviews.llvm.org/D128745#inline-1244757. Yeah, it is somewhat confusing to key the legacy language behavior on ClangABI. I'm not sure there are better choices than inventing new flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134507/new/

https://reviews.llvm.org/D134507



More information about the cfe-commits mailing list