[PATCH] D133705: [HIP] Fix unbundling archive

Mon Sep 26 13:50:41 PDT 2022

yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: clang/test/Driver/clang-offload-bundler.c:410-412
+// Check clang-offload-bundler extracts empty archives if the input file
+// is not an archive when --allow-missing-bundles is specified, otherwise
+// report an error.
----------------
tra wrote:
> Is there a distinction between "an archive, but has no offloading data in it" and "not an archive, at all"?
> I can see how we may want the former case work with `--allow-missing-bundles`, but would we/should we report the error for the latter? I think we should, if we don't. 
I will let clang-offload-bundler keep the original behavior about reporting an error for the "not an archive" case.

I will let clang check the magic bytes of the input file so that it won't pass non-archive files to clang-offload-bundler. This also makes the compilation stages cleaner since there will not be spurious unbundlings.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133705/new/

https://reviews.llvm.org/D133705