[PATCH] D133705: [HIP] Fix unbundling archive

Mon Sep 26 11:52:59 PDT 2022

tra added inline comments.

================
Comment at: clang/test/Driver/clang-offload-bundler.c:410-412
+// Check clang-offload-bundler extracts empty archives if the input file
+// is not an archive when --allow-missing-bundles is specified, otherwise
+// report an error.
----------------
Is there a distinction between "an archive, but has no offloading data in it" and "not an archive, at all"?
I can see how we may want the former case work with `--allow-missing-bundles`, but would we/should we report the error for the latter? I think we should, if we don't. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133705/new/

https://reviews.llvm.org/D133705