[PATCH] D133802: [OpenMP] Remove simplified device runtime handling
Joseph Huber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 13 13:55:10 PDT 2022
jhuber6 marked an inline comment as done.
jhuber6 added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime());
+ OMPBuilder.createTargetDeinit(Bld, IsSPMD, true);
}
----------------
jdoerfert wrote:
> jhuber6 wrote:
> > jdoerfert wrote:
> > > So, follow up for this?
> > Yes, it changes a lot of tests so I wanted to make it a separate patch.
> Talking about tests, if you pick false here less changes happen, I think.
It's mostly meaningless as I'll remove it later anyway. I figured changing it to `true` was closer to what this change means as we always use the full runtime.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133802/new/
https://reviews.llvm.org/D133802
More information about the cfe-commits
mailing list