[PATCH] D133802: [OpenMP] Remove simplified device runtime handling
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 13 13:44:51 PDT 2022
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, two comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048
CGBuilderTy &Bld = CGF.Builder;
- OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime());
+ OMPBuilder.createTargetDeinit(Bld, IsSPMD, true);
}
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > So, follow up for this?
> Yes, it changes a lot of tests so I wanted to make it a separate patch.
Talking about tests, if you pick false here less changes happen, I think.
================
Comment at: clang/test/OpenMP/nvptx_force_full_runtime_SPMD_codegen.cpp:9
#ifndef HEADER
#define HEADER
----------------
Delete this test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133802/new/
https://reviews.llvm.org/D133802
More information about the cfe-commits
mailing list