[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 08:48:28 PDT 2022


ymandel accepted this revision.
ymandel added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:191
+  AnalysisOutputs AO{AnnotatedCode, Context, Target, CFCtx,
+                     Analysis,      InitEnv, {}};
+  if (AI.SetupTest) {
----------------
formatting seems funny here?


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:194
+    auto Error = AI.SetupTest(AO);
+    if (Error) {
+      return Error;
----------------
no braces for a single-statement `if`. could also put the binding in the if condition: `if (auto Error = `...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132377/new/

https://reviews.llvm.org/D132377



More information about the cfe-commits mailing list