[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

weiyi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 29 04:51:05 PDT 2022


wyt added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:88
+/// Arguments for building the dataflow analysis.
+template <typename AnalysisT> struct AnalysisInputs {
+  /// Input code that is analyzed.
----------------
sgatev wrote:
> Why move this? It makes it hard to tell if there are other changes. If there are other changes, let's keep it where it is to have a clean diff and move it in a separate commit.
It was moved as the new parameter declared uses `AnalysisOutputs`, hence `AnalysisOutputs` needs to come before `AnalysisInputs`. The move is now fixed by reordering these two struct declarations in the parent patch where they were first introduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132377/new/

https://reviews.llvm.org/D132377



More information about the cfe-commits mailing list