[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 15:47:07 PDT 2022


gribozavr2 added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:117
+llvm::DenseMap<unsigned, std::string>
+getAnnotationLinesAndContent(AnalysisOutputs &AO);
+
----------------
(if possible)


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:125
+    std::pair<std::string, DataflowAnalysisState<typename AnalysisT::Lattice>>>>
+getAnnotationStates(AnalysisOutputs &AO) {
+  using StateT = DataflowAnalysisState<typename AnalysisT::Lattice>;
----------------
(if possible)


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:179
+checkDataflow(AnalysisInputs<AnalysisT> AI,
+              std::function<llvm::Error(AnalysisOutputs &)> VerifyResults) {
+  // Build AST context from code.
----------------



================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:258-259
+checkDataflow(AnalysisInputs<AnalysisT> AI,
+              std::function<void(llvm::DenseMap<unsigned, std::string> &,
+                                 AnalysisOutputs &)>
+                  VerifyResults) {
----------------



================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:293
+            std::string, DataflowAnalysisState<typename AnalysisT::Lattice>>>,
+        AnalysisOutputs &)>
+        VerifyResults) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132147/new/

https://reviews.llvm.org/D132147



More information about the cfe-commits mailing list