[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 09:12:33 PDT 2022


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm since it matches xcode clang

For the commit message, perhaps the "(Xcode's clang already behaves like this," part should be moved further down, probably to just after "This patch makes it so that", since the "already behaves like this" should refer to the new behaviour.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132258/new/

https://reviews.llvm.org/D132258



More information about the cfe-commits mailing list