[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

[Rong Xu via Phabricator via cfe-commits]

xur added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:589
+
+    if (SampleProfileHasFUnique) {
+      // If profile also uses funqiue, nothing to do here.
----------------
tmsriram wrote:
> Maybe rewrite this slightly as:
> 
> //  If Sample Profile and Instrumented Profile do not agree on symbol uniqification.
> if (SampleProfileHasFunique != ProfileHasFUnique) {
>    if (ProfileHasFUnique) {
>       // trim
>    } else {
>       // Build Map
>    }
> }
Good point. I will change to this form.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132600/new/

https://reviews.llvm.org/D132600