[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

Sriraman Tallam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 14:49:32 PDT 2022


tmsriram accepted this revision.
tmsriram added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:589
+
+    if (SampleProfileHasFUnique) {
+      // If profile also uses funqiue, nothing to do here.
----------------
Maybe rewrite this slightly as:

//  If Sample Profile and Instrumented Profile do not agree on symbol uniqification.
if (SampleProfileHasFunique != ProfileHasFUnique) {
   if (ProfileHasFUnique) {
      // trim
   } else {
      // Build Map
   }
}


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132600/new/

https://reviews.llvm.org/D132600



More information about the cfe-commits mailing list