[PATCH] D131718: [HLSL] Add abs library function
Joshua Batista via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 10:00:36 PDT 2022
bob80905 added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:6130
MarshallingInfoFlag<LangOpts<"HalfArgsAndReturns">>,
ImpliedByAnyOf<[fnative_half_arguments_and_returns.KeyPath]>;
def fdefault_calling_conv_EQ : Joined<["-"], "fdefault-calling-conv=">,
----------------
In Clang.cpp, you removed CmdArgs.push_back("-fallow-half-arguments-and-returns");
But here, you add an extra condition to imply fnative-half-arguments-and-returns
Wouldn't this change the behavior? or is it really alright for the definition below, fallow_half_arguments_and_returns , to be missing hlsl.KeyPath in the implication list?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131718/new/
https://reviews.llvm.org/D131718
More information about the cfe-commits
mailing list