[PATCH] D131718: [HLSL] Add abs library function

Joshua Batista via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 09:54:55 PDT 2022


bob80905 added inline comments.


================
Comment at: clang/test/CodeGenHLSL/builtins/abs.hlsl:20
+
+// CHECK: define noundef double @"?abs_double@@YANN at Z"(
+// CHECK: call double @llvm.fabs.f64(double %0)
----------------
Is there a reason why we don't check the function parameter here, but we do check for function parameters when actually calling the builtin intrinsic on the next call line? 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131718/new/

https://reviews.llvm.org/D131718



More information about the cfe-commits mailing list