[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23
+
+// Test mismatched argument and return types are handled.
+
----------------
tra wrote:
> Is there a particular reason for this test?
> 
> Argument and return value type checks should've been handled by `Sema` based on builtin definition.
> 
> Integer and float conversions should've been done automatically, too.
> 
> We already have tests for all of that.
> 
> 
Will remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132140/new/

https://reviews.llvm.org/D132140