[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 11:41:36 PDT 2022


tra added inline comments.


================
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23
+
+// Test mismatched argument and return types are handled.
+
----------------
Is there a particular reason for this test?

Argument and return value type checks should've been handled by `Sema` based on builtin definition.

Integer and float conversions should've been done automatically, too.

We already have tests for all of that.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132140/new/

https://reviews.llvm.org/D132140



More information about the cfe-commits mailing list