[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 13 04:47:22 PDT 2022


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539
+    // Link to compiler-rt. We directly put the libclang.builtins.a
+    // as input file, other than '-lclang.builtins'.
+    if (RtLib == ToolChain::RLT_CompilerRT) {
----------------
aykevl wrote:
> Suggestion for the second sentence:
> 
> > We directly use libclang.builtins.a as input file, instead of using '-lclang.builtins'.
I will change the comments in my commit. Thanks !


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128133/new/

https://reviews.llvm.org/D128133



More information about the cfe-commits mailing list