[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

Ayke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 13 04:20:29 PDT 2022


aykevl accepted this revision.
aykevl added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539
+    // Link to compiler-rt. We directly put the libclang.builtins.a
+    // as input file, other than '-lclang.builtins'.
+    if (RtLib == ToolChain::RLT_CompilerRT) {
----------------
Suggestion for the second sentence:

> We directly use libclang.builtins.a as input file, instead of using '-lclang.builtins'.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128133/new/

https://reviews.llvm.org/D128133



More information about the cfe-commits mailing list