[PATCH] D131688: [clang][dataflow][NFC] Remove LatticeJoinEffect from framework interfaces

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 09:27:26 PDT 2022


xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.

Returning whether the lattice was changed can be a nice optimization when comparing lattice elements is expensive. On the other hand, it can be one more source of errors. I am fine with either approach, both can make sense depending on whether the goal is to make the interface easier to use or to have superb performance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131688/new/

https://reviews.llvm.org/D131688



More information about the cfe-commits mailing list