[PATCH] D131688: [clang][dataflow][NFC] Remove LatticeJoinEffect from framework interfaces

Eric Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 11 09:02:41 PDT 2022


li.zhe.hua created this revision.
li.zhe.hua added a reviewer: ymandel.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
li.zhe.hua requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Though we request users implementing `join` to return a meaningful
`LatticeJoinEffect`, we never use the returned value. Requiring users
(and the framework) to continue calculating an unused value adds
unnecessary complexity.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131688

Files:
  clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h
  clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
  clang/include/clang/Analysis/FlowSensitive/DataflowLattice.h
  clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h
  clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131688.451876.patch
Type: text/x-patch
Size: 6669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220811/4388b360/attachment-0001.bin>


More information about the cfe-commits mailing list