[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)
Sergei Barannikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 5 05:10:54 PDT 2022
barannikov88 added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.h:63
+ /// Returns Swift ABI info helper for the target.
+ const SwiftABIInfo &getSwiftABIInfo() const { return *SwiftInfo; }
+
----------------
aaron.ballman wrote:
> `SwiftInfo` isn't always initialized to a nonnull pointer; should this have an assert to help point out when someone's forgotten to initialize that properly?
Good point, thank you
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130394/new/
https://reviews.llvm.org/D130394
More information about the cfe-commits
mailing list