[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 5 04:27:42 PDT 2022
aaron.ballman added a comment.
This seems like a reasonable set of changes, but I'd prefer someone more well-versed in codegen make the final call.
================
Comment at: clang/lib/CodeGen/TargetInfo.h:63
+ /// Returns Swift ABI info helper for the target.
+ const SwiftABIInfo &getSwiftABIInfo() const { return *SwiftInfo; }
+
----------------
`SwiftInfo` isn't always initialized to a nonnull pointer; should this have an assert to help point out when someone's forgotten to initialize that properly?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130394/new/
https://reviews.llvm.org/D130394
More information about the cfe-commits
mailing list