[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 3 07:16:10 PDT 2022
erichkeane added a comment.
In D131007#3696495 <https://reviews.llvm.org/D131007#3696495>, @erichkeane wrote:
> In D131007#3696489 <https://reviews.llvm.org/D131007#3696489>, @erichkeane wrote:
>> In D131007#3696486 <https://reviews.llvm.org/D131007#3696486>, @labath wrote:
>>> This seems to break lldb tests, specifically the compilation of this <https://github.com/llvm/llvm-project/blob/main/lldb/test/API/lang/c/cpp_keyword_identifiers/main.c> source file.
>>> The compile fails with an assertion (`Keyword not known to come from a newer Standard or proposed Standard`), so I am assuming that change was not intentional.
>> It was not, thanks for the heads up. Looking into it now.
> I see the problem now, patch incoming as soon as I validate it locally. char8_t was mis-reported as 'future' in C mode, so I was missing a condition.
Fix committed in: bf6db18e52815475baebff2c330763fedac6b5e4 <https://reviews.llvm.org/rGbf6db18e52815475baebff2c330763fedac6b5e4>
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits