[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

Wed Aug 3 07:14:02 PDT 2022

erichkeane added a comment.

In D131007#3696489 <https://reviews.llvm.org/D131007#3696489>, @erichkeane wrote:

> In D131007#3696486 <https://reviews.llvm.org/D131007#3696486>, @labath wrote:
>
>> This seems to break lldb tests, specifically the compilation of this <https://github.com/llvm/llvm-project/blob/main/lldb/test/API/lang/c/cpp_keyword_identifiers/main.c> source file.
>>
>> The compile fails with an assertion (`Keyword not known to come from a newer Standard or proposed Standard`), so I am assuming that change was not intentional.
>
> It was not, thanks for the heads up.  Looking into it now.

I see the problem now, patch incoming as soon as I validate it locally.  char8_t was mis-reported as 'future' in C mode, so I was missing a condition.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131007/new/

https://reviews.llvm.org/D131007