[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

Hmm... I'm a little shocked that didn't error before, while we did the 2nd pass through the destructor.  A little shocking this made it this far...

The fix looks fine to me, I wish I knew why we had that check there, but I got lost in the subversion history.

Anyway, LGTM with 1 nit..  ALSO needs a release note.



================
Comment at: clang/test/SemaCXX/member-class-11.cpp:30
+}
\ No newline at end of file

----------------
Nit: Need newline at end of file (C++98 rule).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130936/new/

https://reviews.llvm.org/D130936