[PATCH] D130936: [SemaCXX] Validate destructor is valid for dependent classes

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 19:00:04 PDT 2022


shafik added a comment.

LGTM but let's have Erich take a look.



================
Comment at: clang/lib/Sema/SemaDecl.cpp:11499
 
-      // FIXME: Shouldn't we be able to perform this check even when the class
-      // type is dependent? Both gcc and edg can handle that.
----------------
The FIXME goes back a while, I wonder how long ago we fixed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130936/new/

https://reviews.llvm.org/D130936



More information about the cfe-commits mailing list