[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:1486
 static bool isAllowedInitiallyIDChar(uint32_t C, const LangOptions &LangOpts) {
+  assert(C > 0x7F && "isAllowedInitiallyIDChar called with a non-ASCII codepoint");
   if (LangOpts.AsmPreprocessor) {
----------------
aaron.ballman wrote:
> nit: 80-col limit
> 
> Also, shouldn't this say it was called with an ASCII codepoint?
It should. I started with `"isAllowedInitiallyIDChar should not be called with a non-ASCII codepoint")` and... yeah, thanks for catching that!
It fits nicely in 80 cols too now :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130750/new/

https://reviews.llvm.org/D130750