[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 29 04:33:55 PDT 2022
cor3ntin updated this revision to Diff 448581.
cor3ntin added a comment.
Fix asser message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130750/new/
https://reviews.llvm.org/D130750
Files:
clang/lib/Lex/Lexer.cpp
Index: clang/lib/Lex/Lexer.cpp
===================================================================
--- clang/lib/Lex/Lexer.cpp
+++ clang/lib/Lex/Lexer.cpp
@@ -1483,13 +1483,13 @@
}
static bool isAllowedInitiallyIDChar(uint32_t C, const LangOptions &LangOpts) {
+ assert(C > 0x7F && "isAllowedInitiallyIDChar called with an ASCII codepoint");
if (LangOpts.AsmPreprocessor) {
return false;
}
if (LangOpts.CPlusPlus || LangOpts.C2x) {
static const llvm::sys::UnicodeCharSet XIDStartChars(XIDStartRanges);
- // '_' doesn't have the XID_Start property but is allowed in C++.
- return C == '_' || XIDStartChars.contains(C);
+ return XIDStartChars.contains(C);
}
if (!isAllowedIDChar(C, LangOpts))
return false;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130750.448581.patch
Type: text/x-patch
Size: 749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220729/131dedfa/attachment.bin>
More information about the cfe-commits
mailing list