[PATCH] D129694: [OPENMP] Make declare target static global externally visible

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added inline comments.


================
Comment at: clang/test/OpenMP/target_update_messages.cpp:17
 
-static int y;
-#pragma omp declare target(y)
-
-void yyy() {
-#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not externally visible.}}
-}
-
 int __attribute__((visibility("hidden"))) z;
 #pragma omp declare target(z)
----------------
jdoerfert wrote:
> There is no test to show you can actually write the update now, is there?
We should probably take the deleted code above and put it in an OpenMP runtime test to make sure it actually works now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129694/new/

https://reviews.llvm.org/D129694