[PATCH] D129694: [OPENMP] Make declare target static global externally visible

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 07:29:23 PDT 2022


jdoerfert added inline comments.


================
Comment at: clang/test/OpenMP/target_update_messages.cpp:17
 
-static int y;
-#pragma omp declare target(y)
-
-void yyy() {
-#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not externally visible.}}
-}
-
 int __attribute__((visibility("hidden"))) z;
 #pragma omp declare target(z)
----------------
There is no test to show you can actually write the update now, is there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129694/new/

https://reviews.llvm.org/D129694



More information about the cfe-commits mailing list