[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

Thu Jul 14 07:24:55 PDT 2022

aaron.ballman added a comment.

In D129689#3651965 <https://reviews.llvm.org/D129689#3651965>, @SebastianPerta wrote:

>>>But can you add some test coverage for this? 
> In clang\test\Headers\limits.cpp there is:
> _Static_assert(USHRT_MAX == (unsigned short)~0ULL, "");
> However as I said this needs a 16 bits target. Looking at the RUN commands at the top of the file I think I can solve this by adding a new RUN command with "-triple msp430"  (since my RL78 port is not upstream yet) so it can catch this. Would this be OK?

That's exactly the solution I'd expect, sounds great!

>>> Please include the full context of the patch with -U99999.
>
> Sorry about this, I actually tried this but the patch showed a lot more than what I've changed, not sure what I did wrong. I also installed arcanist and I'm trying to get familiar with it.

No worries, it takes a while to get used to our systems. I've not use arcanist myself (I generate diff files and upload them manually into Phab), so I'm not much help for debugging what's going on for you. I use `git diff -U9999 main > p.patch`, FWIW.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129689/new/

https://reviews.llvm.org/D129689