[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

Thu Jul 14 07:03:17 PDT 2022

SebastianPerta added a comment.

>>But can you add some test coverage for this? 
In clang\test\Headers\limits.cpp there is:
_Static_assert(USHRT_MAX == (unsigned short)~0ULL, "");
However as I said this needs a 16 bits target. Looking at the RUN commands at the top of the file I think I can solve this by adding a new RUN command with "-triple msp430"  (since my RL78 port is not upstream yet) so it can catch this. Would this be OK?

>> Please include the full context of the patch with -U99999.

Sorry about this, I actually tried this but the patch showed a lot more than what I've changed, not sure what I did wrong. I also installed arcanist and I'm trying to get familiar with it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129689/new/

https://reviews.llvm.org/D129689