[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 05:21:09 PDT 2022


aaron.ballman added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3841
 
+/// matches if ObjCMessageExpr's callee declaration matches
+///
----------------
NoQ wrote:
> Nitpick carryover: needs capital letter and `.`
Don't forget to regen the docs when you fix this, too. :-)


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853
+/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo"))))
+AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee,
+              internal::Matcher<ObjCMethodDecl>, InnerMatcher) {
----------------
Is there a reason why we want a separate matcher here instead of overloading `callee()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129398/new/

https://reviews.llvm.org/D129398



More information about the cfe-commits mailing list